Commit d2de4444 authored by Xin Long's avatar Xin Long Committed by Jakub Kicinski
Browse files

net: igbvf: use skb_csum_is_sctp instead of protocol check 



Using skb_csum_is_sctp is a easier way to validate it's a SCTP CRC
checksum offload packet, and yet it also makes igbvf support SCTP
CRC checksum offload for UDP and GRE encapped packets, just as it
does in igb driver.

Signed-off-by: default avatarXin Long <lucien.xin@gmail.com>
Reviewed-by: default avatarAlexander Duyck <alexanderduyck@fb.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent 8bcf0203

drivers/net/ethernet/intel/igbvf/netdev.c

+1 −13
Original line number Diff line number Diff line
@@ -2072,15 +2072,6 @@ static int igbvf_tso(struct igbvf_ring *tx_ring, 
	return 1;

}



static inline bool igbvf_ipv6_csum_is_sctp(struct sk_buff *skb)

{

	unsigned int offset = 0;



	ipv6_find_hdr(skb, &offset, IPPROTO_SCTP, NULL, NULL);



	return offset == skb_checksum_start_offset(skb);

}



static bool igbvf_tx_csum(struct igbvf_ring *tx_ring, struct sk_buff *skb,

			  u32 tx_flags, __be16 protocol)

{
@@ -2102,10 +2093,7 @@ static bool igbvf_tx_csum(struct igbvf_ring *tx_ring, struct sk_buff *skb, 
		break;

	case offsetof(struct sctphdr, checksum):

		/* validate that this is actually an SCTP request */

		if (((protocol == htons(ETH_P_IP)) &&

		     (ip_hdr(skb)->protocol == IPPROTO_SCTP)) ||

		    ((protocol == htons(ETH_P_IPV6)) &&

		     igbvf_ipv6_csum_is_sctp(skb))) {

		if (skb_csum_is_sctp(skb)) {

			type_tucmd = E1000_ADVTXD_TUCMD_L4T_SCTP;

			break;

		}