Commit d2d1d264 authored by Mark Rutland's avatar Mark Rutland Committed by Catalin Marinas
Browse files

arm64: Make some stacktrace functions private 



Now that open-coded stack unwinds have been converted to
arch_stack_walk(), we no longer need to expose any of unwind_frame(),
walk_stackframe(), or start_backtrace() outside of stacktrace.c.

Make those functions private to stacktrace.c, removing their prototypes
from <asm/stacktrace.h> and marking them static.

Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
Reviewed-by: default avatarMark Brown <broonie@kernel.org>
Cc: Madhavan T. Venkataraman <madvenka@linux.microsoft.com>
Link: https://lore.kernel.org/r/20211129142849.3056714-10-mark.rutland@arm.com


Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
parent 2dad6dc1

arch/arm64/include/asm/stacktrace.h

+0 −6
Original line number Diff line number Diff line
@@ -63,9 +63,6 @@ struct stackframe { 
#endif

};



extern int unwind_frame(struct task_struct *tsk, struct stackframe *frame);

extern void walk_stackframe(struct task_struct *tsk, struct stackframe *frame,

			    bool (*fn)(void *, unsigned long), void *data);

extern void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk,

			   const char *loglvl);
@@ -150,7 +147,4 @@ static inline bool on_accessible_stack(const struct task_struct *tsk, 
	return false;

}



void start_backtrace(struct stackframe *frame, unsigned long fp,

		     unsigned long pc);



#endif	/* __ASM_STACKTRACE_H */

arch/arm64/kernel/stacktrace.c

+7 −5
Original line number Diff line number Diff line
@@ -33,7 +33,7 @@ 
 */





void start_backtrace(struct stackframe *frame, unsigned long fp,

static void start_backtrace(struct stackframe *frame, unsigned long fp,

			    unsigned long pc)

{

	frame->fp = fp;
@@ -63,7 +63,8 @@ void start_backtrace(struct stackframe *frame, unsigned long fp, 
 * records (e.g. a cycle), determined based on the location and fp value of A

 * and the location (but not the fp value) of B.

 */

int notrace unwind_frame(struct task_struct *tsk, struct stackframe *frame)

static int notrace unwind_frame(struct task_struct *tsk,

				struct stackframe *frame)

{

	unsigned long fp = frame->fp;

	struct stack_info info;
@@ -141,7 +142,8 @@ int notrace unwind_frame(struct task_struct *tsk, struct stackframe *frame) 
}

NOKPROBE_SYMBOL(unwind_frame);



void notrace walk_stackframe(struct task_struct *tsk, struct stackframe *frame,

static void notrace walk_stackframe(struct task_struct *tsk,

				    struct stackframe *frame,

				    bool (*fn)(void *, unsigned long), void *data)

{

	while (1) {