Commit d2cd54c2 authored by Yang Li's avatar Yang Li Committed by Linus Walleij
Browse files

pinctrl: ingenic: add missing call to of_node_put() 



In one of the error paths of the for_each_child_of_node() loop in
ingenic_gpio_probe, add missing call to of_node_put().

Fix the following coccicheck warning:
./drivers/pinctrl/pinctrl-ingenic.c:2485:1-23: WARNING: Function
"for_each_child_of_node" should have of_node_put() before return around
line 2489.

Reported-by: default avatarAbaci Robot <abaci@linux.alibaba.com>
Signed-off-by: default avatarYang Li <yang.lee@linux.alibaba.com>
Acked-by: default avatarPaul Cercueil <paul@crapouillou.net>
Link: https://lore.kernel.org/r/1614303297-24178-1-git-send-email-yang.lee@linux.alibaba.com


Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent b37c3578

drivers/pinctrl/pinctrl-ingenic.c

+3 −1
Original line number Diff line number Diff line
@@ -2485,10 +2485,12 @@ static int __init ingenic_pinctrl_probe(struct platform_device *pdev) 
	for_each_child_of_node(dev->of_node, node) {

		if (of_match_node(ingenic_gpio_of_match, node)) {

			err = ingenic_gpio_probe(jzpc, node);

			if (err)

			if (err) {

				of_node_put(node);

				return err;

			}

		}

	}



	return 0;

}