Commit d2be3204 authored by Vladimir Oltean's avatar Vladimir Oltean Committed by Jakub Kicinski
Browse files

net: dsa: modularize DSA_TAG_PROTO_NONE 



There is no reason that I can see why the no-op tagging protocol should
be registered manually, so make it a module and make all drivers which
have any sort of reference to DSA_TAG_PROTO_NONE select it.

Note that I don't know if ksz_get_tag_protocol() really needs this,
or if it's just the logic which is poorly written. All switches seem to
have their own tagging protocol, and DSA_TAG_PROTO_NONE is just a
fallback that never gets used.

Signed-off-by: default avatarVladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c5fb8ead

drivers/net/dsa/Kconfig

+2 −0
Original line number Diff line number Diff line
@@ -18,6 +18,7 @@ config NET_DSA_BCM_SF2 


config NET_DSA_LOOP

	tristate "DSA mock-up Ethernet switch chip support"

	select NET_DSA_TAG_NONE

	select FIXED_PHY

	help

	  This enables support for a fake mock-up switch chip which
@@ -99,6 +100,7 @@ config NET_DSA_SMSC_LAN9303_MDIO 


config NET_DSA_VITESSE_VSC73XX

	tristate

	select NET_DSA_TAG_NONE

	select FIXED_PHY

	select VITESSE_PHY

	select GPIOLIB

drivers/net/dsa/b53/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -2,6 +2,7 @@ 
menuconfig B53

	tristate "Broadcom BCM53xx managed switch support"

	depends on NET_DSA

	select NET_DSA_TAG_NONE

	select NET_DSA_TAG_BRCM

	select NET_DSA_TAG_BRCM_LEGACY

	select NET_DSA_TAG_BRCM_PREPEND

drivers/net/dsa/microchip/Kconfig

+1 −0
Original line number Diff line number Diff line
@@ -3,6 +3,7 @@ menuconfig NET_DSA_MICROCHIP_KSZ_COMMON 
	tristate "Microchip KSZ8795/KSZ9477/LAN937x series switch support"

	depends on NET_DSA

	select NET_DSA_TAG_KSZ

	select NET_DSA_TAG_NONE

	help

	  This driver adds support for Microchip KSZ9477 series switch and

	  KSZ8795/KSZ88x3 switch chips.

net/dsa/Kconfig

+6 −0
Original line number Diff line number Diff line
@@ -18,6 +18,12 @@ if NET_DSA 


# Drivers must select the appropriate tagging format(s)



config NET_DSA_TAG_NONE

	tristate "No-op tag driver"

	help

	  Say Y or M if you want to enable support for switches which don't tag

	  frames over the CPU port.



config NET_DSA_TAG_AR9331

	tristate "Tag driver for Atheros AR9331 SoC with built-in switch"

	help

net/dsa/Makefile

+1 −0
Original line number Diff line number Diff line
@@ -20,6 +20,7 @@ obj-$(CONFIG_NET_DSA_TAG_HELLCREEK) += tag_hellcreek.o 
obj-$(CONFIG_NET_DSA_TAG_KSZ) += tag_ksz.o

obj-$(CONFIG_NET_DSA_TAG_LAN9303) += tag_lan9303.o

obj-$(CONFIG_NET_DSA_TAG_MTK) += tag_mtk.o

obj-$(CONFIG_NET_DSA_TAG_NONE) += tag_none.o

obj-$(CONFIG_NET_DSA_TAG_OCELOT) += tag_ocelot.o

obj-$(CONFIG_NET_DSA_TAG_OCELOT_8021Q) += tag_ocelot_8021q.o

obj-$(CONFIG_NET_DSA_TAG_QCA) += tag_qca.o