Commit d2a16bde authored by Íñigo Huguet's avatar Íñigo Huguet Committed by David S. Miller
Browse files

sfc: add logs explaining XDP_TX/REDIRECT is not available 



If it's not possible to allocate enough channels for XDP, XDP_TX and
XDP_REDIRECT don't work. However, only a message saying that not enough
channels were available was shown, but not saying what are the
consequences in that case. The user didn't know if he/she can use XDP
or not, if the performance is reduced, or what.

Signed-off-by: default avatarÍñigo Huguet <ihuguet@redhat.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 788bc000

drivers/net/ethernet/sfc/efx_channels.c

+4 −0
Original line number Diff line number Diff line
@@ -170,6 +170,8 @@ static int efx_allocate_msix_channels(struct efx_nic *efx, 
		netif_err(efx, drv, efx->net_dev,

			  "Insufficient resources for %d XDP event queues (%d other channels, max %d)\n",

			  n_xdp_ev, n_channels, max_channels);

		netif_err(efx, drv, efx->net_dev,

			  "XDP_TX and XDP_REDIRECT will not work on this interface");

		efx->n_xdp_channels = 0;

		efx->xdp_tx_per_channel = 0;

		efx->xdp_tx_queue_count = 0;
@@ -177,6 +179,8 @@ static int efx_allocate_msix_channels(struct efx_nic *efx, 
		netif_err(efx, drv, efx->net_dev,

			  "Insufficient resources for %d XDP TX queues (%d other channels, max VIs %d)\n",

			  n_xdp_tx, n_channels, efx->max_vis);

		netif_err(efx, drv, efx->net_dev,

			  "XDP_TX and XDP_REDIRECT will not work on this interface");

		efx->n_xdp_channels = 0;

		efx->xdp_tx_per_channel = 0;

		efx->xdp_tx_queue_count = 0;