Commit d2700f40 authored by Thomas Gleixner's avatar Thomas Gleixner Committed by Borislav Petkov (AMD)
Browse files

x86/microcode/intel: Remove pointless mutex 



There is no concurrency.

Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Signed-off-by: default avatarBorislav Petkov (AMD) <bp@alien8.de>
Link: https://lore.kernel.org/r/20230812195728.069849788@linutronix.de
parent d44450c5

arch/x86/kernel/cpu/microcode/intel.c

+2 −22
Original line number Diff line number Diff line
@@ -397,22 +397,6 @@ scan_microcode(void *data, size_t size, struct ucode_cpu_info *uci, bool save) 
	return patch;

}



/*

 * Save this microcode patch. It will be loaded early when a CPU is

 * hot-added or resumes.

 */

static void save_mc_for_early(struct ucode_cpu_info *uci, u8 *mc, unsigned int size)

{

	/* Synchronization during CPU hotplug. */

	static DEFINE_MUTEX(x86_cpu_microcode_mutex);



	mutex_lock(&x86_cpu_microcode_mutex);



	save_microcode_patch(uci, mc, size);



	mutex_unlock(&x86_cpu_microcode_mutex);

}



static bool load_builtin_intel_microcode(struct cpio_data *cp)

{

	unsigned int eax = 1, ebx, ecx = 0, edx;
@@ -829,12 +813,8 @@ static enum ucode_state generic_load_microcode(int cpu, struct iov_iter *iter) 
	vfree(uci->mc);

	uci->mc = (struct microcode_intel *)new_mc;



	/*

	 * If early loading microcode is supported, save this mc into

	 * permanent memory. So it will be loaded early when a CPU is hot added

	 * or resumes.

	 */

	save_mc_for_early(uci, new_mc, new_mc_size);

	/* Save for CPU hotplug */

	save_microcode_patch(uci, new_mc, new_mc_size);



	pr_debug("CPU%d found a matching microcode update with version 0x%x (current=0x%x)\n",

		 cpu, new_rev, uci->cpu_sig.rev);