Commit d26e597d authored by John Fastabend's avatar John Fastabend Committed by David S. Miller
Browse files

bpf: sockmap add missing rcu_read_(un)lock in smap_data_ready 



References to psock must be done inside RCU critical section.

Fixes: 174a79ff ("bpf: sockmap with sk redirect support")
Signed-off-by: default avatarJohn Fastabend <john.fastabend@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2f857d04

kernel/bpf/sockmap.c

+6 −3
Original line number Diff line number Diff line
@@ -227,12 +227,15 @@ static void smap_data_ready(struct sock *sk) 
{

	struct smap_psock *psock;



	write_lock_bh(&sk->sk_callback_lock);

	rcu_read_lock();

	psock = smap_psock_sk(sk);

	if (likely(psock))

	if (likely(psock)) {

		write_lock_bh(&sk->sk_callback_lock);

		strp_data_ready(&psock->strp);

		write_unlock_bh(&sk->sk_callback_lock);

	}

	rcu_read_unlock();

}



static void smap_tx_work(struct work_struct *w)

{