Unverified Commit d2556eda authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: SOF: Intel: hda-stream: remove always true condition 



We test if (!stream) and return and later on re-test for stream.
The second test is always true.

This was detected by cppcheck but only after additional code changes.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarPéter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarKai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://lore.kernel.org/r/20210812231940.172547-3-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 6f28c883

sound/soc/sof/intel/hda-stream.c

+1 −1
Original line number Diff line number Diff line
@@ -198,7 +198,7 @@ hda_dsp_stream_get(struct snd_sof_dev *sdev, int direction, u32 flags) 
	 * in xruns during pause/release in capture scenarios.

	 */

	if (!IS_ENABLED(CONFIG_SND_SOC_SOF_HDA_ALWAYS_ENABLE_DMI_L1))

		if (stream && !(flags & SOF_HDA_STREAM_DMI_L1_COMPATIBLE))

		if (!(flags & SOF_HDA_STREAM_DMI_L1_COMPATIBLE))

			snd_sof_dsp_update_bits(sdev, HDA_DSP_HDA_BAR,

						HDA_VS_INTEL_EM2,

						HDA_VS_INTEL_EM2_L1SEN, 0);