Commit d23386ed authored by Carlos Llamas's avatar Carlos Llamas Committed by Greg Kroah-Hartman
Browse files

binderfs: add extended_error feature entry 



Add extended_error to the binderfs feature list, to help userspace
determine whether the BINDER_GET_EXTENDED_ERROR ioctl is supported by
the binder driver.

Reviewed-by: default avatarChristian Brauner (Microsoft) <brauner@kernel.org>
Acked-by: default avatarTodd Kjos <tkjos@google.com>
Signed-off-by: default avatarCarlos Llamas <cmllamas@google.com>
Link: https://lore.kernel.org/r/20220429235644.697372-4-cmllamas@google.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent bd32889e

drivers/android/binderfs.c

+8 −0
Original line number Diff line number Diff line
@@ -60,6 +60,7 @@ enum binderfs_stats_mode { 


struct binder_features {

	bool oneway_spam_detection;

	bool extended_error;

};



static const struct constant_table binderfs_param_stats[] = {
@@ -75,6 +76,7 @@ static const struct fs_parameter_spec binderfs_fs_parameters[] = { 


static struct binder_features binder_features = {

	.oneway_spam_detection = true,

	.extended_error = true,

};



static inline struct binderfs_info *BINDERFS_SB(const struct super_block *sb)
@@ -615,6 +617,12 @@ static int init_binder_features(struct super_block *sb) 
	if (IS_ERR(dentry))

		return PTR_ERR(dentry);



	dentry = binderfs_create_file(dir, "extended_error",

				      &binder_features_fops,

				      &binder_features.extended_error);

	if (IS_ERR(dentry))

		return PTR_ERR(dentry);



	return 0;

}

tools/testing/selftests/filesystems/binderfs/binderfs_test.c

+1 −0
Original line number Diff line number Diff line
@@ -64,6 +64,7 @@ static int __do_binderfs_test(struct __test_metadata *_metadata) 
		device_path[sizeof(P_tmpdir "/binderfs_XXXXXX/") + BINDERFS_MAX_NAME];

	static const char * const binder_features[] = {

		"oneway_spam_detection",

		"extended_error",

	};



	change_mountns(_metadata);