Commit d229f0fb authored by Fabio M. De Francesco's avatar Fabio M. De Francesco Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: core: Remove rtw_mfree_all_stainfo() 



Remove rtw_mfree_all_stainfo() and the only line of code that calls
it. This function simply takes a spinlock and iterates over a list
with no purpose. That iteration has no side effects.

Signed-off-by: default avatarFabio M. De Francesco <fmdefrancesco@gmail.com>
Acked-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Acked-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20210802005517.12815-1-fmdefrancesco@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e1109da7

drivers/staging/r8188eu/core/rtw_sta_mgt.c

+0 −22
Original line number Diff line number Diff line
@@ -161,34 +161,12 @@ void rtw_mfree_stainfo(struct sta_info *psta) 


}



/*  this function is used to free the memory of lock || sema for all stainfos */

void rtw_mfree_all_stainfo(struct sta_priv *pstapriv);

void rtw_mfree_all_stainfo(struct sta_priv *pstapriv)

{

	struct list_head *plist, *phead;

	struct sta_info *psta = NULL;



	spin_lock_bh(&pstapriv->sta_hash_lock);



	phead = get_list_head(&pstapriv->free_sta_queue);

	plist = phead->next;



	while (phead != plist) {

		psta = container_of(plist, struct sta_info, list);

		plist = plist->next;

	}



	spin_unlock_bh(&pstapriv->sta_hash_lock);

}



static void rtw_mfree_sta_priv_lock(struct sta_priv *pstapriv)

{

#ifdef CONFIG_88EU_AP_MODE

	struct wlan_acl_pool *pacl_list = &pstapriv->acl_list;

#endif



	 rtw_mfree_all_stainfo(pstapriv); /* be done before free sta_hash_lock */



	_rtw_spinlock_free(&pstapriv->free_sta_queue.lock);



	_rtw_spinlock_free(&pstapriv->sta_hash_lock);