Unverified Commit d2294461 authored by Tom Rix's avatar Tom Rix Committed by Mark Brown
Browse files

ASoC: samsung: change gpiod_speaker_power and rx1950_audio from global to static variables 



sparse reports
sound/soc/samsung/rx1950_uda1380.c:131:18: warning: symbol 'gpiod_speaker_power' was not declared. Should it be static?
sound/soc/samsung/rx1950_uda1380.c:231:24: warning: symbol 'rx1950_audio' was not declared. Should it be static?

Both gpiod_speaker_power and rx1950_audio are only used in rx1950_uda1380.c,
so their storage class specifiers should be static.

Fixes: 83d74e35 ("ASoC: samsung: rx1950: turn into platform driver")
Signed-off-by: default avatarTom Rix <trix@redhat.com>
Reviewed-by: default avatarKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20220629185345.910406-1-trix@redhat.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent fc34ece4

sound/soc/samsung/rx1950_uda1380.c

+2 −2
Original line number Original line Diff line number Diff line
@@ -128,7 +128,7 @@ static int rx1950_startup(struct snd_pcm_substream *substream) 
					&hw_rates);

					&hw_rates);

}

}





struct gpio_desc *gpiod_speaker_power;

static struct gpio_desc *gpiod_speaker_power;





static int rx1950_spk_power(struct snd_soc_dapm_widget *w,

static int rx1950_spk_power(struct snd_soc_dapm_widget *w,

				struct snd_kcontrol *kcontrol, int event)

				struct snd_kcontrol *kcontrol, int event)
@@ -228,7 +228,7 @@ static int rx1950_probe(struct platform_device *pdev) 
	return devm_snd_soc_register_card(dev, &rx1950_asoc);

	return devm_snd_soc_register_card(dev, &rx1950_asoc);

}

}





struct platform_driver rx1950_audio = {

static struct platform_driver rx1950_audio = {

	.driver = {

	.driver = {

		.name = "rx1950-audio",

		.name = "rx1950-audio",

		.pm = &snd_soc_pm_ops,

		.pm = &snd_soc_pm_ops,