Commit d228f8d8 authored by Christian König's avatar Christian König Committed by Maarten Lankhorst
Browse files

drm/ttm: soften TTM warnings 



QXL indeed unrefs pinned BOs and the warnings are spamming peoples log files.

Make sure we warn only once until the QXL driver is fixed.

Signed-off-by: default avatarChristian König <christian.koenig@amd.com>
References: https://lore.kernel.org/lkml/YD+eYcMMcdlXB8PY@alley/
Link: https://patchwork.freedesktop.org/patch/422834/


Reviewed-by: default avatarDaniel Vetter <daniel@ffwll.ch>
Signed-off-by: default avatarMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
parent 659ab7a4

drivers/gpu/drm/ttm/ttm_bo.c

+6 −2
Original line number Diff line number Diff line
@@ -136,6 +136,7 @@ void ttm_bo_move_to_lru_tail(struct ttm_buffer_object *bo, 
	struct ttm_bo_device *bdev = bo->bdev;

	struct ttm_resource_manager *man;



	if (!bo->deleted)

		dma_resv_assert_held(bo->base.resv);



	if (bo->pin_count) {
@@ -508,8 +509,11 @@ static void ttm_bo_release(struct kref *kref) 
		 * Make pinned bos immediately available to

		 * shrinkers, now that they are queued for

		 * destruction.

		 *

		 * FIXME: QXL is triggering this. Can be removed when the

		 * driver is fixed.

		 */

		if (WARN_ON(bo->pin_count)) {

		if (WARN_ON_ONCE(bo->pin_count)) {

			bo->pin_count = 0;

			ttm_bo_move_to_lru_tail(bo, &bo->mem, NULL);

		}