Commit d2248ca8 authored by Johan Hovold's avatar Johan Hovold Committed by Greg Kroah-Hartman
Browse files

serial: 8250: rename unlock labels 



Rename a couple of oddly named labels that are used to unlock before
returning after what they do (rather than after the context they are
used in) to improve readability.

Tested-by: default avatarSerge Semin <fancer.lancer@gmail.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: default avatarSerge Semin <fancer.lancer@gmail.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20211015111422.1027-3-johan@kernel.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 211cde4f

drivers/tty/serial/8250/8250_port.c

+5 −5
Original line number Diff line number Diff line
@@ -1338,7 +1338,7 @@ static void autoconfig(struct uart_8250_port *up) 
	up->tx_loadsz = uart_config[port->type].tx_loadsz;



	if (port->type == PORT_UNKNOWN)

		goto out_lock;

		goto out_unlock;



	/*

	 * Reset the UART.
@@ -1355,7 +1355,7 @@ static void autoconfig(struct uart_8250_port *up) 
	else

		serial_out(up, UART_IER, 0);



out_lock:

out_unlock:

	spin_unlock_irqrestore(&port->lock, flags);



	/*
@@ -2714,12 +2714,12 @@ void serial8250_update_uartclk(struct uart_port *port, unsigned int uartclk) 
	mutex_lock(&tport->mutex);



	if (port->uartclk == uartclk)

		goto out_lock;

		goto out_unlock;



	port->uartclk = uartclk;



	if (!tty_port_initialized(tport))

		goto out_lock;

		goto out_unlock;



	termios = &tty->termios;
@@ -2737,7 +2737,7 @@ void serial8250_update_uartclk(struct uart_port *port, unsigned int uartclk) 
	spin_unlock_irqrestore(&port->lock, flags);

	serial8250_rpm_put(up);



out_lock:

out_unlock:

	mutex_unlock(&tport->mutex);

	up_write(&tty->termios_rwsem);

	tty_kref_put(tty);