Commit d2155fe5 authored Jun 30, 2021 by Liu Xiang Committed by Linus Torvalds Jun 30, 2021

mm: compaction: remove duplicate !list_empty(&sublist) check

The list_splice_tail(&sublist, freelist) also do !list_empty(&sublist)
check, so remove the duplicate call.

Link: https://lkml.kernel.org/r/20210609095409.19920-1-liu.xiang@zlingsmart.com


Signed-off-by: Liu Xiang <liu.xiang@zlingsmart.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 17adb230

mm/compaction.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -1297,7 +1297,6 @@ move_freelist_head(struct list_head freelist, struct page freepage)

		if (!list_is_last(freelist, &freepage->lru)) {
		list_cut_before(&sublist, freelist, &freepage->lru);
		if (!list_empty(&sublist))
		list_splice_tail(&sublist, freelist);
		}
		}
		@@ -1315,7 +1314,6 @@ move_freelist_tail(struct list_head freelist, struct page freepage)

		if (!list_is_first(freelist, &freepage->lru)) {
		list_cut_position(&sublist, freelist, &freepage->lru);
		if (!list_empty(&sublist))
		list_splice_tail(&sublist, freelist);
		}
		}