Commit d2154b0a authored by Kuniyuki Iwashima's avatar Kuniyuki Iwashima Committed by David S. Miller
Browse files

net: Fix a data-race around sysctl_tstamp_allow_data. 



While reading sysctl_tstamp_allow_data, it can be changed
concurrently.  Thus, we need to add READ_ONCE() to its reader.

Fixes: b245be1f ("net-timestamp: no-payload only sysctl")
Signed-off-by: default avatarKuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 7de6d09f

net/core/skbuff.c

+1 −1
Original line number Diff line number Diff line
@@ -4797,7 +4797,7 @@ static bool skb_may_tx_timestamp(struct sock *sk, bool tsonly) 
{

	bool ret;



	if (likely(sysctl_tstamp_allow_data || tsonly))

	if (likely(READ_ONCE(sysctl_tstamp_allow_data) || tsonly))

		return true;



	read_lock_bh(&sk->sk_callback_lock);