Commit d1d28bd9 authored by Lianjie Zhang's avatar Lianjie Zhang Committed by Vlastimil Babka
Browse files

mm/slub: use helper macro __ATTR_XX_MODE for SLAB_ATTR(_RO) 



This allows more concise code, and VERIFY_OCTAL_PERMISSIONS() can help
validate any future change.

Signed-off-by: default avatarLianjie Zhang <zhanglianjie@uniontech.com>
Acked-by: default avatarDavid Rientjes <rientjes@google.com>
Signed-off-by: default avatarVlastimil Babka <vbabka@suse.cz>
Link: https://lore.kernel.org/r/20220306073818.15089-1-zhanglianjie@uniontech.com
parent 7d6b6cc3

mm/slub.c

+2 −4
Original line number Diff line number Diff line
@@ -5344,12 +5344,10 @@ struct slab_attribute { 
};



#define SLAB_ATTR_RO(_name) \

	static struct slab_attribute _name##_attr = \

	__ATTR(_name, 0400, _name##_show, NULL)

	static struct slab_attribute _name##_attr = __ATTR_RO_MODE(_name, 0400)



#define SLAB_ATTR(_name) \

	static struct slab_attribute _name##_attr =  \

	__ATTR(_name, 0600, _name##_show, _name##_store)

	static struct slab_attribute _name##_attr = __ATTR_RW_MODE(_name, 0600)



static ssize_t slab_size_show(struct kmem_cache *s, char *buf)

{