Commit d158367c authored by Nirmoy Das's avatar Nirmoy Das Committed by Matthew Auld
Browse files

drm/i915: return -EIO on lmem setup failure 



Caller of setup_lmem() ignores -ENODEV but failing
to setup lmem on dGPU isn't ignorable error.

Signed-off-by: default avatarNirmoy Das <nirmoy.das@intel.com>
Reviewed-by: default avatarMatthew Auld <matthew.auld@intel.com>
Signed-off-by: default avatarMatthew Auld <matthew.auld@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220511153746.14142-1-nirmoy.das@intel.com
parent ca10b9d6

drivers/gpu/drm/i915/gt/intel_region_lmem.c

+2 −2
Original line number Diff line number Diff line
@@ -108,7 +108,7 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt) 
		flat_ccs_base = (flat_ccs_base >> XEHPSDV_CCS_BASE_SHIFT) * SZ_64K;



		if (GEM_WARN_ON(lmem_size < flat_ccs_base))

			return ERR_PTR(-ENODEV);

			return ERR_PTR(-EIO);



		tile_stolen = lmem_size - flat_ccs_base;
@@ -131,7 +131,7 @@ static struct intel_memory_region *setup_lmem(struct intel_gt *gt) 
	io_start = pci_resource_start(pdev, 2);

	io_size = min(pci_resource_len(pdev, 2), lmem_size);

	if (!io_size)

		return ERR_PTR(-ENODEV);

		return ERR_PTR(-EIO);



	min_page_size = HAS_64K_PAGES(i915) ? I915_GTT_PAGE_SIZE_64K :

						I915_GTT_PAGE_SIZE_4K;