Commit d134ad25 authored by Jason Wang's avatar Jason Wang Committed by Corey Minyard
Browse files

ipmi: ssif: replace strlcpy with strscpy 



The strlcpy should not be used because it doesn't limit the source
length. So that it will lead some potential bugs.

But the strscpy doesn't require reading memory from the src string
beyond the specified "count" bytes, and since the return value is
easier to error-check than strlcpy()'s. In addition, the implementation
is robust to the string changing out from underneath it, unlike the
current strlcpy() implementation.

Thus, replace strlcpy with strscpy.

Signed-off-by: default avatarJason Wang <wangborong@cdjrlc.com>
Message-Id: <20211222032707.1912186-1-wangborong@cdjrlc.com>
Signed-off-by: default avatarCorey Minyard <cminyard@mvista.com>
parent 72815992

drivers/char/ipmi/ipmi_ssif.c

+1 −1
Original line number Diff line number Diff line
@@ -1354,7 +1354,7 @@ static int ssif_detect(struct i2c_client *client, struct i2c_board_info *info) 
	if (rv)

		rv = -ENODEV;

	else

		strlcpy(info->type, DEVICE_NAME, I2C_NAME_SIZE);

		strscpy(info->type, DEVICE_NAME, I2C_NAME_SIZE);

	kfree(resp);

	return rv;

}