Commit d12b8951 authored Dec 14, 2020 by Yang Shi Committed by Linus Torvalds Dec 15, 2020

mm: truncate_complete_page() does not exist any more

Patch series "mm: misc migrate cleanup and improvement", v3.

This patch (of 5):

The commit 9f4e41f4 ("mm: refactor truncate_complete_page()")
refactored truncate_complete_page(), and it is not existed anymore,
correct the comment in vmscan and migrate to avoid confusion.

Link: https://lkml.kernel.org/r/20201113205359.556831-1-shy828301@gmail.com
Link: https://lkml.kernel.org/r/20201113205359.556831-2-shy828301@gmail.com


Signed-off-by: Yang Shi <shy828301@gmail.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Zi Yan <ziy@nvidia.com>
Cc: Song Liu <songliubraving@fb.com>
Cc: Mel Gorman <mgorman@suse.de>
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 0060ef3b

mm/migrate.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1106,7 +1106,7 @@ static int __unmap_and_move(struct page page, struct page newpage,
		* and treated as swapcache but it has no rmap yet.
		* Calling try_to_unmap() against a page->mapping==NULL page will
		* trigger a BUG. So handle it here.
		* 2. An orphaned page (see truncate_complete_page) might have
		* 2. An orphaned page (see truncate_cleanup_page) might have
		* fs-private metadata. The page can be picked up due to memory
		* offlining. Everywhere else except page reclaim, the page is
		* invisible to the vm, so the page can not be migrated. So try to

mm/vmscan.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1390,7 +1390,7 @@ static unsigned int shrink_page_list(struct list_head *page_list,
		*
		* Rarely, pages can have buffers and no ->mapping. These are
		* the pages which were not successfully invalidated in
		* truncate_complete_page(). We try to drop those buffers here
		* truncate_cleanup_page(). We try to drop those buffers here
		* and if that worked, and the page is no longer mapped into
		* process address space (page_count == 1) it can be freed.
		* Otherwise, leave the page on the LRU so it is swappable.