Commit d1199b94 authored by Harshad Shirwadkar's avatar Harshad Shirwadkar Committed by Theodore Ts'o
Browse files

ext4: update fast commit TODOs 



This series takes care of a couple of TODOs and adds new ones. Update
the TODOs section to reflect current state and future work that needs
to happen.

Signed-off-by: default avatarHarshad Shirwadkar <harshadshirwadkar@gmail.com>
Link: https://lore.kernel.org/r/20211223202140.2061101-5-harshads@google.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 0915e464

fs/ext4/fast_commit.c

+6 −8
Original line number Diff line number Diff line
@@ -156,15 +156,13 @@ 
 *    fast commit recovery even if that area is invalidated by later full

 *    commits.

 *

 * 1) Make fast commit atomic updates more fine grained. Today, a fast commit

 *    eligible update must be protected within ext4_fc_start_update() and

 *    ext4_fc_stop_update(). These routines are called at much higher

 *    routines. This can be made more fine grained by combining with

 *    ext4_journal_start().

 * 1) Fast commit's commit path locks the entire file system during fast

 *    commit. This has significant performance penalty. Instead of that, we

 *    should use ext4_fc_start/stop_update functions to start inode level

 *    updates from ext4_journal_start/stop. Once we do that we can drop file

 *    system locking during commit path.

 *

 * 2) Same above for ext4_fc_start_ineligible() and ext4_fc_stop_ineligible()

 *

 * 3) Handle more ineligible cases.

 * 2) Handle more ineligible cases.

 */



#include <trace/events/ext4.h>