Commit d0f3ef36 authored by Kamal Heib's avatar Kamal Heib Committed by Jason Gunthorpe
Browse files

RDMA/core: Fix return code when modify_device isn't supported 

The proper return code is "-EOPNOTSUPP" when modify_device callback is not
supported.

Link: https://lore.kernel.org/r/20190923104158.5331-2-kamalheib1@gmail.com


Signed-off-by: default avatarKamal Heib <kamalheib1@gmail.com>
Reviewed-by: default avatarJason Gunthorpe <jgg@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 050dbddf

drivers/infiniband/core/device.c

+1 −1
Original line number Diff line number Diff line
@@ -2365,7 +2365,7 @@ int ib_modify_device(struct ib_device *device, 
		     struct ib_device_modify *device_modify)

{

	if (!device->ops.modify_device)

		return -ENOSYS;

		return -EOPNOTSUPP;



	return device->ops.modify_device(device, device_modify_mask,

					 device_modify);

drivers/infiniband/core/sysfs.c

+1 −1
Original line number Diff line number Diff line
@@ -1268,7 +1268,7 @@ static ssize_t node_desc_store(struct device *device, 
	int ret;



	if (!dev->ops.modify_device)

		return -EIO;

		return -EOPNOTSUPP;



	memcpy(desc.node_desc, buf, min_t(int, count, IB_DEVICE_NODE_DESC_MAX));

	ret = ib_modify_device(dev, IB_DEVICE_MODIFY_NODE_DESC, &desc);