Commit d0df264f authored by Daniel Lezcano's avatar Daniel Lezcano
Browse files

thermal/core: Remove pointless thermal_zone_device_reset() function 



The function thermal_zone_device_reset() is called in the
thermal_zone_device_register() which allocates and initialize the
structure. The passive field is already zero-ed by the allocation, the
function is useless.

Call directly thermal_zone_device_init() instead and
thermal_zone_device_reset().

Signed-off-by: default avatarDaniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20201222181110.1231977-1-daniel.lezcano@linaro.org
parent b39d2dd5

drivers/thermal/thermal_core.c

+1 −7
Original line number Diff line number Diff line
@@ -478,12 +478,6 @@ static void thermal_zone_device_init(struct thermal_zone_device *tz) 
		pos->initialized = false;

}



static void thermal_zone_device_reset(struct thermal_zone_device *tz)

{

	tz->passive = 0;

	thermal_zone_device_init(tz);

}



static int thermal_zone_device_set_mode(struct thermal_zone_device *tz,

					enum thermal_device_mode mode)

{
@@ -1363,7 +1357,7 @@ thermal_zone_device_register(const char *type, int trips, int mask, 


	INIT_DELAYED_WORK(&tz->poll_queue, thermal_zone_device_check);



	thermal_zone_device_reset(tz);

	thermal_zone_device_init(tz);

	/* Update the new thermal zone and mark it as already updated. */

	if (atomic_cmpxchg(&tz->need_update, 1, 0))

		thermal_zone_device_update(tz, THERMAL_EVENT_UNSPECIFIED);