Unverified Commit d0c99ffe authored by Mark Brown's avatar Mark Brown
Browse files

regmap: Allow reads from write only registers with the flat cache



The flat cache is intended for devices that need the lowest overhead so
doesn't track any sparseness.

Signed-off-by: default avatarMark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20230617-regmap-kunit-read-writeonly-flat-v1-1-efd3ed66dec6@kernel.org


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent 3e47b887
Loading
Loading
Loading
Loading
+12 −3
Original line number Diff line number Diff line
@@ -252,9 +252,18 @@ static void read_writeonly(struct kunit *test)
	for (i = 0; i < BLOCK_TEST_SIZE; i++)
		data->read[i] = false;

	/* Try to read all the registers, the writeonly one should fail */
	for (i = 0; i < BLOCK_TEST_SIZE; i++)
		KUNIT_EXPECT_EQ(test, i != 5, regmap_read(map, i, &val) == 0);
	/*
	 * Try to read all the registers, the writeonly one should
	 * fail if we aren't using the flat cache.
	 */
	for (i = 0; i < BLOCK_TEST_SIZE; i++) {
		if (t->type != REGCACHE_FLAT) {
			KUNIT_EXPECT_EQ(test, i != 5,
					regmap_read(map, i, &val) == 0);
		} else {
			KUNIT_EXPECT_EQ(test, 0, regmap_read(map, i, &val));
		}
	}

	/* Did we trigger a hardware access? */
	KUNIT_EXPECT_FALSE(test, data->read[5]);