Commit d0a70ab1 authored by Guoqing Jiang's avatar Guoqing Jiang Committed by Jens Axboe
Browse files

block/rnbd-clt: Move add_disk(dev->gd) to rnbd_clt_setup_gen_disk 



It makes more sense to add gendisk in rnbd_clt_setup_gen_disk, instead
of do it in rnbd_clt_map_device.

Signed-off-by: default avatarGuoqing Jiang <guoqing.jiang@gmx.com>
Reviewed-by: default avatarDanil Kipnis <danil.kipnis@cloud.ionos.com>
Signed-off-by: default avatarGioh Kim <gi-oh.kim@cloud.ionos.com>
Signed-off-by: default avatarJack Wang <jinpu.wang@cloud.ionos.com>
Reviewed-by: default avatarChaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Link: https://lore.kernel.org/r/20210419073722.15351-6-gi-oh.kim@ionos.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 8b7f0511

drivers/block/rnbd/rnbd-clt.c

+1 −2
Original line number Diff line number Diff line
@@ -1352,6 +1352,7 @@ static void rnbd_clt_setup_gen_disk(struct rnbd_clt_dev *dev, int idx) 


	if (!dev->rotational)

		blk_queue_flag_set(QUEUE_FLAG_NONROT, dev->queue);

	add_disk(dev->gd);

}



static int rnbd_client_setup_device(struct rnbd_clt_dev *dev)
@@ -1553,8 +1554,6 @@ struct rnbd_clt_dev *rnbd_clt_map_device(const char *sessname, 
		       dev->max_hw_sectors, dev->rotational, dev->wc, dev->fua);



	mutex_unlock(&dev->lock);



	add_disk(dev->gd);

	rnbd_clt_put_sess(sess);



	return dev;