Commit d031aa06 authored by Lee Jones's avatar Lee Jones Committed by Alex Deucher
Browse files

drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Fix worthy function headers, demote barely documented one 



Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1556: warning: Function parameter or member 'acg_freq' not described in 'vega10_populate_single_gfx_level'
 drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1621: warning: Function parameter or member 'current_soc_did' not described in 'vega10_populate_single_soc_level'
 drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1621: warning: Function parameter or member 'current_vol_index' not described in 'vega10_populate_single_soc_level'
 drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1621: warning: Excess function parameter 'current_socclk_level' description in 'vega10_populate_single_soc_level'
 drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1757: warning: Function parameter or member 'current_mem_vid' not described in 'vega10_populate_single_memory_level'
 drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1757: warning: Function parameter or member 'current_memclk_level' not described in 'vega10_populate_single_memory_level'
 drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1757: warning: Function parameter or member 'current_mem_soc_vind' not described in 'vega10_populate_single_memory_level'
 drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:2871: warning: Function parameter or member 'bitmap' not described in 'vega10_start_dpm'

Cc: Evan Quan <evan.quan@amd.com>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: "Christian König" <christian.koenig@amd.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 2fed1746

drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c

+6 −4
Original line number Diff line number Diff line
@@ -1549,6 +1549,7 @@ static int vega10_populate_smc_link_levels(struct pp_hwmgr *hwmgr) 
 * @hwmgr:      the address of the hardware manager

 * @gfx_clock:  the GFX clock to use to populate the structure.

 * @current_gfxclk_level:  location in PPTable for the SMC GFXCLK structure.

 * @acg_freq:   ACG frequenty to return (MHz)

 */

static int vega10_populate_single_gfx_level(struct pp_hwmgr *hwmgr,

		uint32_t gfx_clock, PllSetting_t *current_gfxclk_level,
@@ -1612,7 +1613,8 @@ static int vega10_populate_single_gfx_level(struct pp_hwmgr *hwmgr, 
 *

 * @hwmgr:     the address of the hardware manager.

 * @soc_clock: the SOC clock to use to populate the structure.

 * @current_socclk_level: location in PPTable for the SMC SOCCLK structure.

 * @current_soc_did:   DFS divider to pass back to caller

 * @current_vol_index: index of current VDD to pass back to caller

 * return:      0 on success

 */

static int vega10_populate_single_soc_level(struct pp_hwmgr *hwmgr,
@@ -1744,7 +1746,7 @@ static void vega10_populate_vddc_soc_levels(struct pp_hwmgr *hwmgr) 
	}

}



/**

/*

 * Populates single SMC GFXCLK structure using the provided clock.

 *

 * @hwmgr:     the address of the hardware manager.
@@ -2864,7 +2866,7 @@ static int vega10_stop_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap) 
 * Tell SMC to enabled the supported DPMs.

 *

 * @hwmgr:   the address of the powerplay hardware manager.

 * @bitmap  bitmap for the features to enabled.

 * @bitmap:  bitmap for the features to enabled.

 * return:  0 on at least one DPM is successfully enabled.

 */

static int vega10_start_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap)