Commit d01db9cf authored by Chao Yu's avatar Chao Yu Committed by Zizhi Wo
Browse files

f2fs: fix to truncate meta inode pages forcely 

stable inclusion
from stable-v6.6.23
commit c92f2927df860a60ba815d3ee610a944b92a8694
category: bugfix
bugzilla: https://gitee.com/src-openeuler/kernel/issues/I9HKE5
CVE: CVE-2024-26869

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=c92f2927df860a60ba815d3ee610a944b92a8694



--------------------------------

[ Upstream commit 9f0c4a46be1fe9b97dbe66d49204c1371e3ece65 ]

Below race case can cause data corruption:

Thread A				GC thread
					- gc_data_segment
					 - ra_data_block
					  - locked meta_inode page
- f2fs_inplace_write_data
 - invalidate_mapping_pages
 : fail to invalidate meta_inode page
   due to lock failure or dirty|writeback
   status
 - f2fs_submit_page_bio
 : write last dirty data to old blkaddr
					 - move_data_block
					  - load old data from meta_inode page
					  - f2fs_submit_page_write
					  : write old data to new blkaddr

Because invalidate_mapping_pages() will skip invalidating page which
has unclear status including locked, dirty, writeback and so on, so
we need to use truncate_inode_pages_range() instead of
invalidate_mapping_pages() to make sure meta_inode page will be dropped.

Fixes: 6aa58d8a ("f2fs: readahead encrypted block during GC")
Fixes: e3b49ea3 ("f2fs: invalidate META_MAPPING before IPU/DIO write")
Signed-off-by: default avatarChao Yu <chao@kernel.org>
Signed-off-by: default avatarJaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>

Conflicts:
	fs/f2fs/data.c
	fs/f2fs/gc.c
	fs/f2fs/segment.c
	fs/f2fs/f2fs.h
Signed-off-by: default avatarZizhi Wo <wozizhi@huawei.com>
parent 2e6dcc46

fs/f2fs/checkpoint.c

+3 −2
Original line number Diff line number Diff line
@@ -1551,8 +1551,9 @@ static int do_checkpoint(struct f2fs_sb_info *sbi, struct cp_control *cpc) 
	 */

	if (f2fs_sb_has_encrypt(sbi) || f2fs_sb_has_verity(sbi) ||

		f2fs_sb_has_compression(sbi))

		invalidate_mapping_pages(META_MAPPING(sbi),

				MAIN_BLKADDR(sbi), MAX_BLKADDR(sbi) - 1);

		f2fs_bug_on(sbi,

			invalidate_inode_pages2_range(META_MAPPING(sbi),

				MAIN_BLKADDR(sbi), MAX_BLKADDR(sbi) - 1));



	f2fs_release_ino_entry(sbi, false);

fs/f2fs/data.c

+1 −2
Original line number Diff line number Diff line
@@ -1421,8 +1421,7 @@ static int __allocate_data_block(struct dnode_of_data *dn, int seg_type) 
	f2fs_allocate_data_block(sbi, NULL, old_blkaddr, &dn->data_blkaddr,

				&sum, seg_type, NULL);

	if (GET_SEGNO(sbi, old_blkaddr) != NULL_SEGNO)

		invalidate_mapping_pages(META_MAPPING(sbi),

					old_blkaddr, old_blkaddr);

		f2fs_truncate_meta_inode_pages(sbi, old_blkaddr, 1);

	f2fs_update_data_blkaddr(dn, dn->data_blkaddr);



	/*

fs/f2fs/f2fs.h

+26 −0
Original line number Diff line number Diff line
@@ -4127,6 +4127,32 @@ static inline bool is_journalled_quota(struct f2fs_sb_info *sbi) 
	return false;

}



static inline void f2fs_truncate_meta_inode_pages(struct f2fs_sb_info *sbi,

					block_t blkaddr, unsigned int cnt)

{

	bool need_submit = false;

	int i = 0;



	do {

		struct page *page;



		page = find_get_page(META_MAPPING(sbi), blkaddr + i);

		if (page) {

			if (PageWriteback(page))

				need_submit = true;

			f2fs_put_page(page, 0);

		}

	} while (++i < cnt && !need_submit);



	if (need_submit)

		f2fs_submit_merged_write_cond(sbi, sbi->meta_inode,

							NULL, 0, DATA);



	truncate_inode_pages_range(META_MAPPING(sbi),

			F2FS_BLK_TO_BYTES((loff_t)blkaddr),

			F2FS_BLK_END_BYTES((loff_t)(blkaddr + cnt - 1)));

}



#define EFSBADCRC	EBADMSG		/* Bad CRC detected */

#define EFSCORRUPTED	EUCLEAN		/* Filesystem is corrupted */

fs/f2fs/gc.c

+1 −2
Original line number Diff line number Diff line
@@ -1257,8 +1257,7 @@ static int move_data_block(struct inode *inode, block_t bidx, 
	memcpy(page_address(fio.encrypted_page),

				page_address(mpage), PAGE_SIZE);

	f2fs_put_page(mpage, 1);

	invalidate_mapping_pages(META_MAPPING(fio.sbi),

				fio.old_blkaddr, fio.old_blkaddr);

	f2fs_truncate_meta_inode_pages(fio.sbi, fio.old_blkaddr, 1);



	set_page_dirty(fio.encrypted_page);

	if (clear_page_dirty_for_io(fio.encrypted_page))

fs/f2fs/segment.c

+5 −8
Original line number Diff line number Diff line
@@ -2311,7 +2311,7 @@ void f2fs_invalidate_blocks(struct f2fs_sb_info *sbi, block_t addr) 
	if (addr == NEW_ADDR || addr == COMPRESS_ADDR)

		return;



	invalidate_mapping_pages(META_MAPPING(sbi), addr, addr);

	f2fs_truncate_meta_inode_pages(sbi, addr, 1);



	/* add it into sit main buffer */

	down_write(&sit_i->sentry_lock);
@@ -3468,8 +3468,7 @@ static void do_write_page(struct f2fs_summary *sum, struct f2fs_io_info *fio) 
	f2fs_allocate_data_block(fio->sbi, fio->page, fio->old_blkaddr,

			&fio->new_blkaddr, sum, type, fio);

	if (GET_SEGNO(fio->sbi, fio->old_blkaddr) != NULL_SEGNO)

		invalidate_mapping_pages(META_MAPPING(fio->sbi),

					fio->old_blkaddr, fio->old_blkaddr);

		f2fs_truncate_meta_inode_pages(fio->sbi, fio->old_blkaddr, 1);



	/* writeout dirty page into bdev */

	f2fs_submit_page_write(fio);
@@ -3555,8 +3554,7 @@ int f2fs_inplace_write_data(struct f2fs_io_info *fio) 
	}



	if (fio->post_read)

		invalidate_mapping_pages(META_MAPPING(sbi),

				fio->new_blkaddr, fio->new_blkaddr);

		f2fs_truncate_meta_inode_pages(sbi, fio->new_blkaddr, 1);



	stat_inc_inplace_blocks(fio->sbi);
@@ -3644,8 +3642,7 @@ void f2fs_do_replace_block(struct f2fs_sb_info *sbi, struct f2fs_summary *sum, 
		update_sit_entry(sbi, new_blkaddr, 1);

	}

	if (GET_SEGNO(sbi, old_blkaddr) != NULL_SEGNO) {

		invalidate_mapping_pages(META_MAPPING(sbi),

					old_blkaddr, old_blkaddr);

		f2fs_truncate_meta_inode_pages(sbi, old_blkaddr, 1);

		if (!from_gc)

			update_segment_mtime(sbi, old_blkaddr, 0);

		update_sit_entry(sbi, old_blkaddr, -1);
@@ -3733,7 +3730,7 @@ void f2fs_wait_on_block_writeback_range(struct inode *inode, block_t blkaddr, 
	for (i = 0; i < len; i++)

		f2fs_wait_on_block_writeback(inode, blkaddr + i);



	invalidate_mapping_pages(META_MAPPING(sbi), blkaddr, blkaddr + len - 1);

	f2fs_truncate_meta_inode_pages(sbi, blkaddr, len);

}



static int read_compacted_summaries(struct f2fs_sb_info *sbi)