Commit d0146756 authored by Miaohe Lin's avatar Miaohe Lin Committed by Linus Torvalds
Browse files

hugetlbfs: remove useless BUG_ON(!inode) in hugetlbfs_setattr() 

When we reach here with inode = NULL, we should have crashed as inode has
already been dereferenced via hstate_inode.  So this BUG_ON(!inode) does
not take effect and should be removed.

Link: https://lkml.kernel.org/r/20210118110700.52506-1-linmiaohe@huawei.com


Signed-off-by: default avatarMiaohe Lin <linmiaohe@huawei.com>
Reviewed-by: default avatarMike Kravetz <mike.kravetz@oracle.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent a4fa34cd

fs/hugetlbfs/inode.c

+0 −2
Original line number Diff line number Diff line
@@ -761,8 +761,6 @@ static int hugetlbfs_setattr(struct user_namespace *mnt_userns, 
	unsigned int ia_valid = attr->ia_valid;

	struct hugetlbfs_inode_info *info = HUGETLBFS_I(inode);



	BUG_ON(!inode);



	error = setattr_prepare(&init_user_ns, dentry, attr);

	if (error)

		return error;