Commit cfdf0d9a authored by Yajun Deng's avatar Yajun Deng Committed by David S. Miller
Browse files

rtnetlink: use nlmsg_notify() in rtnetlink_send() 



The netlink_{broadcast, unicast} don't deal with 'if (err > 0' statement
but nlmsg_{multicast, unicast} do. The nlmsg_notify() contains them.
so use nlmsg_notify() instead. so that the caller wouldn't deal with
'if (err > 0' statement.

v2: use nlmsg_notify() will do well.

Signed-off-by: default avatarYajun Deng <yajun.deng@linux.dev>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 63a9192b

net/core/rtnetlink.c

+1 −8
Original line number Diff line number Diff line
@@ -710,15 +710,8 @@ static int rtnl_link_fill(struct sk_buff *skb, const struct net_device *dev) 
int rtnetlink_send(struct sk_buff *skb, struct net *net, u32 pid, unsigned int group, int echo)

{

	struct sock *rtnl = net->rtnl;

	int err = 0;



	NETLINK_CB(skb).dst_group = group;

	if (echo)

		refcount_inc(&skb->users);

	netlink_broadcast(rtnl, skb, pid, group, GFP_KERNEL);

	if (echo)

		err = netlink_unicast(rtnl, skb, pid, MSG_DONTWAIT);

	return err;

	return nlmsg_notify(rtnl, skb, pid, group, echo, GFP_KERNEL);

}



int rtnl_unicast(struct sk_buff *skb, struct net *net, u32 pid)