Commit cfa3b797 authored by Maor Gottlieb's avatar Maor Gottlieb Committed by Jason Gunthorpe
Browse files

RDMA/mlx5: Fix query DCT via DEVX 

When executing DEVX command to query QP object, we need to take the QP
type from the mlx5_ib_qp struct which hold the driver specific QP types as
well, such as DC.

Fixes: 34613eb1 ("IB/mlx5: Enable modify and query verbs objects via DEVX")
Link: https://lore.kernel.org/r/6eee15d63f09bb70787488e0cf96216e2957f5aa.1621413654.git.leonro@nvidia.com


Reviewed-by: default avatarYishai Hadas <yishaih@nvidia.com>
Signed-off-by: default avatarMaor Gottlieb <maorg@nvidia.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 889d916b

drivers/infiniband/hw/mlx5/devx.c

+2 −4
Original line number Diff line number Diff line
@@ -630,9 +630,8 @@ static bool devx_is_valid_obj_id(struct uverbs_attr_bundle *attrs, 
	case UVERBS_OBJECT_QP:

	{

		struct mlx5_ib_qp *qp = to_mqp(uobj->object);

		enum ib_qp_type	qp_type = qp->ibqp.qp_type;



		if (qp_type == IB_QPT_RAW_PACKET ||

		if (qp->type == IB_QPT_RAW_PACKET ||

		    (qp->flags & IB_QP_CREATE_SOURCE_QPN)) {

			struct mlx5_ib_raw_packet_qp *raw_packet_qp =

							 &qp->raw_packet_qp;
@@ -649,10 +648,9 @@ static bool devx_is_valid_obj_id(struct uverbs_attr_bundle *attrs, 
					       sq->tisn) == obj_id);

		}



		if (qp_type == MLX5_IB_QPT_DCT)

		if (qp->type == MLX5_IB_QPT_DCT)

			return get_enc_obj_id(MLX5_CMD_OP_CREATE_DCT,

					      qp->dct.mdct.mqp.qpn) == obj_id;



		return get_enc_obj_id(MLX5_CMD_OP_CREATE_QP,

				      qp->ibqp.qp_num) == obj_id;

	}