Commit cf8f5cea authored by Lee Jones's avatar Lee Jones Committed by Jason Gunthorpe
Browse files

RDMA/sw/rdmavt/mr: Fix some issues related to formatting and missing descriptions 

Fixes the following W=1 kernel build warning(s):

 drivers/infiniband/sw/rdmavt/mr.c:380: warning: Function parameter or member 'virt_addr' not described in 'rvt_reg_user_mr'
 drivers/infiniband/sw/rdmavt/mr.c:449: warning: Function parameter or member 'qp' not described in 'rvt_dereg_clean_qp_cb'
 drivers/infiniband/sw/rdmavt/mr.c:449: warning: Function parameter or member 'v' not described in 'rvt_dereg_clean_qp_cb'
 drivers/infiniband/sw/rdmavt/mr.c:466: warning: Function parameter or member 'mr' not described in 'rvt_dereg_clean_qps'
 drivers/infiniband/sw/rdmavt/mr.c:484: warning: Function parameter or member 'mr' not described in 'rvt_check_refs'
 drivers/infiniband/sw/rdmavt/mr.c:484: warning: Function parameter or member 't' not described in 'rvt_check_refs'
 drivers/infiniband/sw/rdmavt/mr.c:513: warning: Function parameter or member 'mr' not described in 'rvt_mr_has_lkey'
 drivers/infiniband/sw/rdmavt/mr.c:513: warning: Function parameter or member 'lkey' not described in 'rvt_mr_has_lkey'
 drivers/infiniband/sw/rdmavt/mr.c:526: warning: Function parameter or member 'ss' not described in 'rvt_ss_has_lkey'
 drivers/infiniband/sw/rdmavt/mr.c:526: warning: Function parameter or member 'lkey' not described in 'rvt_ss_has_lkey'
 drivers/infiniband/sw/rdmavt/mr.c:551: warning: Function parameter or member 'udata' not described in 'rvt_dereg_mr'

Link: https://lore.kernel.org/r/20210121094519.2044049-27-lee.jones@linaro.org


Cc: Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>
Cc: Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>
Cc: Doug Ledford <dledford@redhat.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: linux-rdma@vger.kernel.org
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
Signed-off-by: default avatarJason Gunthorpe <jgg@nvidia.com>
parent 8e9a197e

drivers/infiniband/sw/rdmavt/mr.c

+11 −10
Original line number Diff line number Diff line
@@ -369,6 +369,7 @@ struct ib_mr *rvt_get_dma_mr(struct ib_pd *pd, int acc) 
 * @pd: protection domain for this memory region

 * @start: starting userspace address

 * @length: length of region to register

 * @virt_addr: associated virtual address

 * @mr_access_flags: access flags for this memory region

 * @udata: unused by the driver

 *
@@ -438,8 +439,8 @@ struct ib_mr *rvt_reg_user_mr(struct ib_pd *pd, u64 start, u64 length, 


/**

 * rvt_dereg_clean_qp_cb - callback from iterator

 * @qp - the qp

 * @v - the mregion (as u64)

 * @qp: the qp

 * @v: the mregion (as u64)

 *

 * This routine fields the callback for all QPs and

 * for QPs in the same PD as the MR will call the
@@ -457,7 +458,7 @@ static void rvt_dereg_clean_qp_cb(struct rvt_qp *qp, u64 v) 


/**

 * rvt_dereg_clean_qps - find QPs for reference cleanup

 * @mr - the MR that is being deregistered

 * @mr: the MR that is being deregistered

 *

 * This routine iterates RC QPs looking for references

 * to the lkey noted in mr.
@@ -471,8 +472,8 @@ static void rvt_dereg_clean_qps(struct rvt_mregion *mr) 


/**

 * rvt_check_refs - check references

 * @mr - the megion

 * @t - the caller identification

 * @mr: the megion

 * @t: the caller identification

 *

 * This routine checks MRs holding a reference during

 * when being de-registered.
@@ -506,8 +507,8 @@ static int rvt_check_refs(struct rvt_mregion *mr, const char *t) 


/**

 * rvt_mr_has_lkey - is MR

 * @mr - the mregion

 * @lkey - the lkey

 * @mr: the mregion

 * @lkey: the lkey

 */

bool rvt_mr_has_lkey(struct rvt_mregion *mr, u32 lkey)

{
@@ -516,8 +517,8 @@ bool rvt_mr_has_lkey(struct rvt_mregion *mr, u32 lkey) 


/**

 * rvt_ss_has_lkey - is mr in sge tests

 * @ss - the sge state

 * @lkey

 * @ss: the sge state

 * @lkey: the lkey

 *

 * This code tests for an MR in the indicated

 * sge state.
@@ -540,7 +541,7 @@ bool rvt_ss_has_lkey(struct rvt_sge_state *ss, u32 lkey) 
/**

 * rvt_dereg_mr - unregister and free a memory region

 * @ibmr: the memory region to free

 *

 * @udata: unused by the driver

 *

 * Note that this is called to free MRs created by rvt_get_dma_mr()

 * or rvt_reg_user_mr().