Commit cf5ac2d4 authored by Hans de Goede's avatar Hans de Goede
Browse files

platform/x86: int3472/discrete: Ensure the clk/power enable pins are in output mode 



acpi_get_and_request_gpiod() does not take a gpio_lookup_flags argument
specifying that the pins direction should be initialized to a specific
value.

This means that in some cases the pins might be left in input mode, causing
the gpiod_set() calls made to enable the clk / regulator to not work.

One example of this problem is the clk-enable GPIO for the ov01a1s sensor
on a Dell Latitude 9420 being left in input mode causing the clk to
never get enabled.

Explicitly set the direction of the pins to output to fix this.

Fixes: 5de691bf ("platform/x86: Add intel_skl_int3472 driver")
Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
Reviewed-by: default avatarAndy Shevchenko <andy@kernel.org>
Reviewed-by: default avatarDaniel Scally <djrscally@gmail.com>
Reviewed-by: default avatarSakari Ailus <sakari.ailus@linux.intel.com>
Link: https://lore.kernel.org/r/20230111201426.947853-1-hdegoede@redhat.com
parent ccb32e2b

drivers/platform/x86/intel/int3472/clk_and_regulator.c

+3 −0
Original line number Diff line number Diff line
@@ -181,6 +181,9 @@ int skl_int3472_register_regulator(struct int3472_discrete_device *int3472, 
		return PTR_ERR(int3472->regulator.gpio);

	}



	/* Ensure the pin is in output mode and non-active state */

	gpiod_direction_output(int3472->regulator.gpio, 0);



	cfg.dev = &int3472->adev->dev;

	cfg.init_data = &init_data;

	cfg.ena_gpiod = int3472->regulator.gpio;

drivers/platform/x86/intel/int3472/discrete.c

+4 −0
Original line number Diff line number Diff line
@@ -168,6 +168,8 @@ static int skl_int3472_map_gpio_to_clk(struct int3472_discrete_device *int3472, 
			return (PTR_ERR(gpio));



		int3472->clock.ena_gpio = gpio;

		/* Ensure the pin is in output mode and non-active state */

		gpiod_direction_output(int3472->clock.ena_gpio, 0);

		break;

	case INT3472_GPIO_TYPE_PRIVACY_LED:

		gpio = acpi_get_and_request_gpiod(path, pin, "int3472,privacy-led");
@@ -175,6 +177,8 @@ static int skl_int3472_map_gpio_to_clk(struct int3472_discrete_device *int3472, 
			return (PTR_ERR(gpio));



		int3472->clock.led_gpio = gpio;

		/* Ensure the pin is in output mode and non-active state */

		gpiod_direction_output(int3472->clock.led_gpio, 0);

		break;

	default:

		dev_err(int3472->dev, "Invalid GPIO type 0x%02x for clock\n", type);