Commit cf4f5530 authored by Wen Gu's avatar Wen Gu Committed by David S. Miller
Browse files

net/smc: Make sure the link_id is unique 



The link_id is supposed to be unique, but smcr_next_link_id() doesn't
skip the used link_id as expected. So the patch fixes this.

Fixes: 026c381f ("net/smc: introduce link_idx for link group array")
Signed-off-by: default avatarWen Gu <guwen@linux.alibaba.com>
Reviewed-by: default avatarTony Lu <tonylu@linux.alibaba.com>
Acked-by: default avatarKarsten Graul <kgraul@linux.ibm.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 938cca9e

net/smc/smc_core.c

+2 −1
Original line number Diff line number Diff line
@@ -708,13 +708,14 @@ static u8 smcr_next_link_id(struct smc_link_group *lgr) 
	int i;



	while (1) {

again:

		link_id = ++lgr->next_link_id;

		if (!link_id)	/* skip zero as link_id */

			link_id = ++lgr->next_link_id;

		for (i = 0; i < SMC_LINKS_PER_LGR_MAX; i++) {

			if (smc_link_usable(&lgr->lnk[i]) &&

			    lgr->lnk[i].link_id == link_id)

				continue;

				goto again;

		}

		break;

	}