Commit cf4a8693 authored by Shaoqin Huang's avatar Shaoqin Huang Committed by Paolo Bonzini
Browse files

KVM: x86/mmu: Check every prev_roots in __kvm_mmu_free_obsolete_roots() 



When freeing obsolete previous roots, check prev_roots as intended, not
the current root.

Signed-off-by: default avatarShaoqin Huang <shaoqin.huang@intel.com>
Fixes: 527d5cd7 ("KVM: x86/mmu: Zap only obsolete roots if a root shadow page is zapped")
Message-Id: <20220607005905.2933378-1-shaoqin.huang@intel.com>
Cc: stable@vger.kernel.org
Reviewed-by: default avatarSean Christopherson <seanjc@google.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
parent 3e684903

arch/x86/kvm/mmu/mmu.c

+1 −1
Original line number Diff line number Diff line
@@ -5179,7 +5179,7 @@ static void __kvm_mmu_free_obsolete_roots(struct kvm *kvm, struct kvm_mmu *mmu) 
		roots_to_free |= KVM_MMU_ROOT_CURRENT;



	for (i = 0; i < KVM_MMU_NUM_PREV_ROOTS; i++) {

		if (is_obsolete_root(kvm, mmu->root.hpa))

		if (is_obsolete_root(kvm, mmu->prev_roots[i].hpa))

			roots_to_free |= KVM_MMU_ROOT_PREVIOUS(i);

	}