Commit cf4590b9 authored by Vincent Mailhol's avatar Vincent Mailhol Committed by Jakub Kicinski
Browse files

net: devlink: clean-up empty devlink_ops::info_get() 



devlink_ops::info_get() is now optional and devlink will continue to
report information even if that callback gets removed.

Remove all the empty devlink_ops::info_get() callbacks from the
drivers.

Signed-off-by: default avatarVincent Mailhol <mailhol.vincent@wanadoo.fr>
Reviewed-by: default avatarJacob Keller <jacob.e.keller@intel.com>
Reviewed-by: default avatarJiri Pirko <jiri@nvidia.com>
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
parent c5cd7c86

drivers/net/ethernet/fungible/funeth/funeth_devlink.c

+0 −7
Original line number Diff line number Diff line
@@ -3,14 +3,7 @@ 
#include "funeth.h"

#include "funeth_devlink.h"



static int fun_dl_info_get(struct devlink *dl, struct devlink_info_req *req,

			   struct netlink_ext_ack *extack)

{

	return 0;

}



static const struct devlink_ops fun_dl_ops = {

	.info_get = fun_dl_info_get,

};



struct devlink *fun_devlink_alloc(struct device *dev)

drivers/net/ethernet/marvell/octeontx2/af/rvu_devlink.c

+0 −7
Original line number Diff line number Diff line
@@ -1547,14 +1547,7 @@ static int rvu_devlink_eswitch_mode_set(struct devlink *devlink, u16 mode, 
	return 0;

}



static int rvu_devlink_info_get(struct devlink *devlink, struct devlink_info_req *req,

				struct netlink_ext_ack *extack)

{

	return 0;

}



static const struct devlink_ops rvu_devlink_ops = {

	.info_get = rvu_devlink_info_get,

	.eswitch_mode_get = rvu_devlink_eswitch_mode_get,

	.eswitch_mode_set = rvu_devlink_eswitch_mode_set,

};

drivers/net/ethernet/marvell/octeontx2/nic/otx2_devlink.c

+0 −8
Original line number Diff line number Diff line
@@ -77,15 +77,7 @@ static const struct devlink_param otx2_dl_params[] = { 
			     otx2_dl_mcam_count_validate),

};



static int otx2_devlink_info_get(struct devlink *devlink,

				 struct devlink_info_req *req,

				 struct netlink_ext_ack *extack)

{

	return 0;

}



static const struct devlink_ops otx2_devlink_ops = {

	.info_get = otx2_devlink_info_get,

};



int otx2_register_dl(struct otx2_nic *pfvf)