Commit cf2cc0bf authored by Jakub Kicinski's avatar Jakub Kicinski Committed by David S. Miller
Browse files

ethtool: fec: fix FEC_NONE check 



Dan points out we need to use the mask not the bit (which is 0).

Reported-by: default avatarkernel test robot <lkp@intel.com>
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Fixes: 42ce127d ("ethtool: fec: sanitize ethtool_fecparam->fec")
Signed-off-by: default avatarJakub Kicinski <kuba@kernel.org>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent ad1cd785

net/ethtool/ioctl.c

+1 −1
Original line number Diff line number Diff line
@@ -2586,7 +2586,7 @@ static int ethtool_set_fecparam(struct net_device *dev, void __user *useraddr) 
	if (copy_from_user(&fecparam, useraddr, sizeof(fecparam)))

		return -EFAULT;



	if (!fecparam.fec || fecparam.fec & ETHTOOL_FEC_NONE_BIT)

	if (!fecparam.fec || fecparam.fec & ETHTOOL_FEC_NONE)

		return -EINVAL;



	fecparam.active_fec = 0;