Commit cf2a85ef authored by Kees Cook's avatar Kees Cook Committed by Peter Zijlstra
Browse files

leaking_addresses: Always print a trailing newline 

For files that lack trailing newlines and match a leaking address (e.g.
wchan[1]), the leaking_addresses.pl report would run together with the
next line, making things look corrupted.

Unconditionally remove the newline on input, and write it back out on
output.

[1] https://lore.kernel.org/all/20210103142726.GC30643@xsang-OptiPlex-9020/



Signed-off-by: default avatarKees Cook <keescook@chromium.org>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lkml.kernel.org/r/20211008111626.151570317@infradead.org
parent 54354c6a

scripts/leaking_addresses.pl

+2 −1
Original line number Diff line number Diff line
@@ -455,8 +455,9 @@ sub parse_file 


	open my $fh, "<", $file or return;

	while ( <$fh> ) {

		chomp;

		if (may_leak_address($_)) {

			print $file . ': ' . $_;

			printf("$file: $_\n");

		}

	}

	close $fh;