Commit cf25ef6b authored by Johan Hovold's avatar Johan Hovold Committed by Bartosz Golaszewski
Browse files

gpio: fix gpio-device list corruption 



Make sure to hold the gpio_lock when removing the gpio device from the
gpio_devices list (when dropping the last reference) to avoid corrupting
the list when there are concurrent accesses.

Fixes: ff2b1359 ("gpio: make the gpiochip a real device")
Cc: stable@vger.kernel.org      # 4.6
Reviewed-by: default avatarSaravana Kannan <saravanak@google.com>
Signed-off-by: default avatarJohan Hovold <johan@kernel.org>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent a6112998

drivers/gpio/gpiolib.c

+4 −0
Original line number Diff line number Diff line
@@ -475,8 +475,12 @@ EXPORT_SYMBOL_GPL(gpiochip_line_is_valid); 
static void gpiodevice_release(struct device *dev)

{

	struct gpio_device *gdev = container_of(dev, struct gpio_device, dev);

	unsigned long flags;



	spin_lock_irqsave(&gpio_lock, flags);

	list_del(&gdev->list);

	spin_unlock_irqrestore(&gpio_lock, flags);



	ida_free(&gpio_ida, gdev->id);

	kfree_const(gdev->label);

	kfree(gdev->descs);