Commit ced081a4 authored by Luca Stefani's avatar Luca Stefani Committed by Greg Kroah-Hartman
Browse files

binder: Return EFAULT if we fail BINDER_ENABLE_ONEWAY_SPAM_DETECTION 



All the other ioctl paths return EFAULT in case the
copy_from_user/copy_to_user call fails, make oneway spam detection
follow the same paradigm.

Fixes: a7dc1e6f ("binder: tell userspace to dump current backtrace when detected oneway spamming")
Acked-by: default avatarTodd Kjos <tkjos@google.com>
Acked-by: default avatarChristian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: default avatarLuca Stefani <luca.stefani.ge1@gmail.com>
Link: https://lore.kernel.org/r/20210506193726.45118-1-luca.stefani.ge1@gmail.com


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 9183f01b

drivers/android/binder.c

+1 −1
Original line number Diff line number Diff line
@@ -4918,7 +4918,7 @@ static long binder_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) 
		uint32_t enable;



		if (copy_from_user(&enable, ubuf, sizeof(enable))) {

			ret = -EINVAL;

			ret = -EFAULT;

			goto err;

		}

		binder_inner_proc_lock(proc);