Commit ce234de7 authored by Jie Wang's avatar Jie Wang Committed by Jiantao Xiao
Browse files

net: hns3: add wait until mac link down 

driver inclusion
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I7D6IP


CVE: NA

----------------------------------------------------------------------

In some configure flow of hns3 driver, for example, change mtu, it will
disable MAC through firmware before configuration. But firmware disables
MAC asynchronously. The rx traffic may be not stopped in this case.

So fixes it by waiting until mac link is down.

Fixes: a9775bb6 ("net: hns3: fix set and get link ksettings issue")
Signed-off-by: default avatarJie Wang <wangjie125@huawei.com>
parent b2d3f011

drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c

+10 −2
Original line number Diff line number Diff line
@@ -7997,6 +7997,8 @@ static void hclge_enable_fd(struct hnae3_handle *handle, bool enable) 


int hclge_cfg_mac_mode(struct hclge_dev *hdev, bool enable)

{

#define HCLGE_LINK_STATUS_WAIT_CNT  3



	struct hclge_desc desc;

	struct hclge_config_mac_mode_cmd *req =

		(struct hclge_config_mac_mode_cmd *)desc.data;
@@ -8021,13 +8023,19 @@ int hclge_cfg_mac_mode(struct hclge_dev *hdev, bool enable) 
	req->txrx_pad_fcs_loop_en = cpu_to_le32(loop_en);



	ret = hclge_cmd_send(&hdev->hw, &desc, 1);

	if (ret)

	if (ret) {

		dev_err(&hdev->pdev->dev, "failed to %s mac, ret = %d.\n",

			enable ? "enable" : "disable", ret);



		return ret;

	}



	if (!enable)

		hclge_mac_link_status_wait(hdev, HCLGE_LINK_STATUS_DOWN,

					   HCLGE_LINK_STATUS_WAIT_CNT);



	return 0;

}



static int hclge_config_switch_param(struct hclge_dev *hdev, int vfid,

				     u8 switch_param, u8 param_mask)

{