Commit ce1fdb06 authored by Wolfram Sang's avatar Wolfram Sang Committed by Paolo Abeni
Browse files

sh_eth: remove open coded netif_running() 



It had a purpose back in the days, but today we have a handy helper.

Reported-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: default avatarLeon Romanovsky <leonro@nvidia.com>
Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Tested-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: default avatarFlorian Fainelli <f.fainelli@gmail.com>
Link: https://lore.kernel.org/r/20230321065826.2044-1-wsa+renesas@sang-engineering.com


Signed-off-by: default avatarPaolo Abeni <pabeni@redhat.com>
parent 7849c42d

drivers/net/ethernet/renesas/sh_eth.c

+1 −5
Original line number Diff line number Diff line
@@ -2441,8 +2441,6 @@ static int sh_eth_open(struct net_device *ndev) 


	netif_start_queue(ndev);



	mdp->is_opened = 1;



	return ret;



out_free_irq:
@@ -2565,7 +2563,7 @@ static struct net_device_stats *sh_eth_get_stats(struct net_device *ndev) 
	if (mdp->cd->no_tx_cntrs)

		return &ndev->stats;



	if (!mdp->is_opened)

	if (!netif_running(ndev))

		return &ndev->stats;



	sh_eth_update_stat(ndev, &ndev->stats.tx_dropped, TROCR);
@@ -2614,8 +2612,6 @@ static int sh_eth_close(struct net_device *ndev) 
	/* Free all the skbuffs in the Rx queue and the DMA buffer. */

	sh_eth_ring_free(ndev);



	mdp->is_opened = 0;



	pm_runtime_put(&mdp->pdev->dev);



	return 0;

drivers/net/ethernet/renesas/sh_eth.h

+0 −1
Original line number Diff line number Diff line
@@ -560,7 +560,6 @@ struct sh_eth_private { 


	unsigned no_ether_link:1;

	unsigned ether_link_active_low:1;

	unsigned is_opened:1;

	unsigned wol_enabled:1;

};