Commit ce1f3ebb authored by Liang He's avatar Liang He Committed by Zheng Zengkai
Browse files

mmc: cavium-octeon: Add of_node_put() when breaking out of loop 

stable inclusion
from stable-v5.10.137
commit 3bed7b98117551f59ab89b1426885063ee1ce133
category: bugfix
bugzilla: https://gitee.com/openeuler/kernel/issues/I60PLB

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?id=3bed7b98117551f59ab89b1426885063ee1ce133



--------------------------------

[ Upstream commit 19bbb49a ]

In octeon_mmc_probe(), we should call of_node_put() when breaking
out of for_each_child_of_node() which has increased and decreased
the refcount during each iteration.

Fixes: 01d95843 ("mmc: cavium: Add MMC support for Octeon SOCs.")
Signed-off-by: default avatarLiang He <windhl@126.com>
Acked-by: default avatarRobert Richter <rric@kernel.org>
Link: https://lore.kernel.org/r/20220719095216.1241601-1-windhl@126.com


Signed-off-by: default avatarUlf Hansson <ulf.hansson@linaro.org>
Signed-off-by: default avatarSasha Levin <sashal@kernel.org>
Signed-off-by: default avatarZheng Zengkai <zhengzengkai@huawei.com>
Reviewed-by: default avatarWei Li <liwei391@huawei.com>
parent 3b9dc30e

drivers/mmc/host/cavium-octeon.c

+1 −0
Original line number Diff line number Diff line
@@ -277,6 +277,7 @@ static int octeon_mmc_probe(struct platform_device *pdev) 
		if (ret) {

			dev_err(&pdev->dev, "Error populating slots\n");

			octeon_mmc_set_shared_power(host, 0);

			of_node_put(cn);

			goto error;

		}

		i++;