Commit ce0338df authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: test for non-standard signatures 



Warn on non-standard signature styles.

Signed-off-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent b34a26f3

scripts/checkpatch.pl

+5 −1
Original line number Diff line number Diff line
@@ -1600,13 +1600,17 @@ sub process { 


# Check signature styles

		if (!$in_header_lines &&

		    $line =~ /^(\s*)($signature_tags)(\s*)(.*)/) {

		    $line =~ /^(\s*)([a-z0-9_-]+by:|$signature_tags)(\s*)(.*)/i) {

			my $space_before = $1;

			my $sign_off = $2;

			my $space_after = $3;

			my $email = $4;

			my $ucfirst_sign_off = ucfirst(lc($sign_off));



			if ($sign_off !~ /$signature_tags/) {

				WARN("BAD_SIGN_OFF",

				     "Non-standard signature: $sign_off\n" . $herecurr);

			}

			if (defined $space_before && $space_before ne "") {

				WARN("BAD_SIGN_OFF",

				     "Do not use whitespace before $ucfirst_sign_off\n" . $herecurr);