Commit cdccc03a authored by Anand Jain's avatar Anand Jain Committed by David Sterba
Browse files

btrfs: remove stale comment about the btrfs_show_devname 



There were few lockdep warnings because btrfs_show_devname() was using
device_list_mutex as recorded in the commits:

  0ccd0528 ("btrfs: fix a possible umount deadlock")
  779bf3fe ("btrfs: fix lock dep warning, move scratch dev out of device_list_mutex and uuid_mutex")

And finally, commit 88c14590 ("btrfs: use RCU in btrfs_show_devname
for device list traversal") removed the device_list_mutex from
btrfs_show_devname for performance reasons.

This patch removes a stale comment about the function
btrfs_show_devname and device_list_mutex.

Signed-off-by: default avatarAnand Jain <anand.jain@oracle.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent b7cb29e6

fs/btrfs/volumes.c

+0 −7
Original line number Diff line number Diff line
@@ -2305,13 +2305,6 @@ void btrfs_destroy_dev_replace_tgtdev(struct btrfs_device *tgtdev) 


	mutex_unlock(&fs_devices->device_list_mutex);



	/*

	 * The update_dev_time() with in btrfs_scratch_superblocks()

	 * may lead to a call to btrfs_show_devname() which will try

	 * to hold device_list_mutex. And here this device

	 * is already out of device list, so we don't have to hold

	 * the device_list_mutex lock.

	 */

	btrfs_scratch_superblocks(tgtdev->fs_info, tgtdev->bdev,

				  tgtdev->name->str);