Commit cdb330f4 authored by Luis Henriques's avatar Luis Henriques Committed by Ilya Dryomov
Browse files

ceph: don't WARN if we're still opening a session to an MDS 



If MDSs aren't available while mounting a filesystem, the session state
will transition from SESSION_OPENING to SESSION_CLOSING.  And in that
scenario check_session_state() will be called from delayed_work() and
trigger this WARN.

Avoid this by only WARNing after a session has already been established
(i.e., the s_ttl will be different from 0).

Fixes: 62575e27 ("ceph: check session state after bumping session->s_seq")
Signed-off-by: default avatarLuis Henriques <lhenriques@suse.de>
Reviewed-by: default avatarJeff Layton <jlayton@kernel.org>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent ed9eb710

fs/ceph/mds_client.c

+1 −1
Original line number Diff line number Diff line
@@ -4456,7 +4456,7 @@ bool check_session_state(struct ceph_mds_session *s) 
		break;

	case CEPH_MDS_SESSION_CLOSING:

		/* Should never reach this when we're unmounting */

		WARN_ON_ONCE(true);

		WARN_ON_ONCE(s->s_ttl);

		fallthrough;

	case CEPH_MDS_SESSION_NEW:

	case CEPH_MDS_SESSION_RESTARTING: