Commit cda83bb8 authored by wuchi's avatar wuchi Committed by Andrew Morton
Browse files

lib/radix-tree: remove unused argument of insert_entries 

insert_entries() doesn't use the 'bool replace' argument, and the function
is only used locally, remove the argument.

The historical context of the unused argument is as follow:

2: commit <3a08cd52> (radix tree: Remove multiorder support)
  Remove the code related to macro CONFIG_RADIX_TREE_MULTIORDER
to convert to the xArray.
  Without the macro, there is no need to retain the argument.

1: commit <175542f5> (radix-tree: add radix_tree_join)
  Add insert_entries(..., bool replace) function, depending on the
macro CONFIG_RADIX_TREE_MULTIORDER definition, the implementation
is different. Notice that the implementation without the macro doesn't
use the argument.

[Matthew Wilcox: add historical context for argument]

Link: https://lkml.kernel.org/r/20220625135324.72574-1-wuchi.zero@gmail.com


Signed-off-by: default avatarwuchi <wuchi.zero@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 045ed31e

lib/radix-tree.c

+2 −2
Original line number Diff line number Diff line
@@ -677,7 +677,7 @@ static void radix_tree_free_nodes(struct radix_tree_node *node) 
}



static inline int insert_entries(struct radix_tree_node *node,

		void __rcu **slot, void *item, bool replace)

		void __rcu **slot, void *item)

{

	if (*slot)

		return -EEXIST;
@@ -711,7 +711,7 @@ int radix_tree_insert(struct radix_tree_root *root, unsigned long index, 
	if (error)

		return error;



	error = insert_entries(node, slot, item, false);

	error = insert_entries(node, slot, item);

	if (error < 0)

		return error;