Commit cd59cdef authored by Jinjie Ruan's avatar Jinjie Ruan Committed by Ilya Dryomov
Browse files

rbd: use list_for_each_entry() helper 



Convert list_for_each() to list_for_each_entry() so that the tmp
list_head pointer and list_entry() call are no longer needed, which
can reduce a few lines of code. No functional changed.

Signed-off-by: default avatarJinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: default avatarIlya Dryomov <idryomov@gmail.com>
Signed-off-by: default avatarIlya Dryomov <idryomov@gmail.com>
parent e6a28d63

drivers/block/rbd.c

+1 −3
Original line number Diff line number Diff line
@@ -7199,7 +7199,6 @@ static void rbd_dev_remove_parent(struct rbd_device *rbd_dev) 
static ssize_t do_rbd_remove(const char *buf, size_t count)

{

	struct rbd_device *rbd_dev = NULL;

	struct list_head *tmp;

	int dev_id;

	char opt_buf[6];

	bool force = false;
@@ -7226,8 +7225,7 @@ static ssize_t do_rbd_remove(const char *buf, size_t count) 


	ret = -ENOENT;

	spin_lock(&rbd_dev_list_lock);

	list_for_each(tmp, &rbd_dev_list) {

		rbd_dev = list_entry(tmp, struct rbd_device, node);

	list_for_each_entry(rbd_dev, &rbd_dev_list, node) {

		if (rbd_dev->dev_id == dev_id) {

			ret = 0;

			break;