Commit cd4f186d authored by Shay Drory's avatar Shay Drory Committed by Saeed Mahameed
Browse files

net/mlx5: E-switch, Coverity: overlapping copy 



When a capability is set via port function caps callbacks, a memcpy() is
performed in which the source and the target are the same address, e.g.:
the copy is redundant. Hence, Remove it.
Discovered by Coverity.

Fixes: 7db98396 ("net/mlx5: E-Switch, Implement devlink port function cmds to control RoCE")
Fixes: e5b9642a ("net/mlx5: E-Switch, Implement devlink port function cmds to control migratable")
Signed-off-by: default avatarShay Drory <shayd@nvidia.com>
Reviewed-by: default avatarMark Bloch <mbloch@nvidia.com>
Signed-off-by: default avatarSaeed Mahameed <saeedm@nvidia.com>
parent d515d63c

drivers/net/ethernet/mellanox/mlx5/core/eswitch_offloads.c

+0 −4
Original line number Diff line number Diff line
@@ -4143,8 +4143,6 @@ int mlx5_devlink_port_fn_migratable_set(struct devlink_port *port, bool enable, 
	}



	hca_caps = MLX5_ADDR_OF(query_hca_cap_out, query_ctx, capability);

	memcpy(hca_caps, MLX5_ADDR_OF(query_hca_cap_out, query_ctx, capability),

	       MLX5_UN_SZ_BYTES(hca_cap_union));

	MLX5_SET(cmd_hca_cap_2, hca_caps, migratable, 1);



	err = mlx5_vport_set_other_func_cap(esw->dev, hca_caps, vport->vport,
@@ -4236,8 +4234,6 @@ int mlx5_devlink_port_fn_roce_set(struct devlink_port *port, bool enable, 
	}



	hca_caps = MLX5_ADDR_OF(query_hca_cap_out, query_ctx, capability);

	memcpy(hca_caps, MLX5_ADDR_OF(query_hca_cap_out, query_ctx, capability),

	       MLX5_UN_SZ_BYTES(hca_cap_union));

	MLX5_SET(cmd_hca_cap, hca_caps, roce, enable);



	err = mlx5_vport_set_other_func_cap(esw->dev, hca_caps, vport_num,