Commit cd455ebb authored by Jing Yao's avatar Jing Yao Committed by Greg Kroah-Hartman
Browse files

most: usb: replace snprintf in show functions with sysfs_emit 



coccicheck complains about the use of snprintf() in sysfs show
functions:
WARNING use scnprintf or sprintf

Use sysfs_emit instead of scnprintf, snprintf or sprintf makes more
sense.

Reported-by: default avatarZeal Robot <zealci@zte.com.cn>
Signed-off-by: default avatarJing Yao <yao.jing2@zte.com.cn>
Link: https://lore.kernel.org/r/20211110025341.136194-1-yao.jing2@zte.com.cn


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 1f8ff525

drivers/most/most_usb.c

+2 −2
Original line number Diff line number Diff line
@@ -831,7 +831,7 @@ static ssize_t value_show(struct device *dev, struct device_attribute *attr, 
	int err;



	if (sysfs_streq(name, "arb_address"))

		return snprintf(buf, PAGE_SIZE, "%04x\n", dci_obj->reg_addr);

		return sysfs_emit(buf, "%04x\n", dci_obj->reg_addr);



	if (sysfs_streq(name, "arb_value"))

		reg_addr = dci_obj->reg_addr;
@@ -843,7 +843,7 @@ static ssize_t value_show(struct device *dev, struct device_attribute *attr, 
	if (err < 0)

		return err;



	return snprintf(buf, PAGE_SIZE, "%04x\n", val);

	return sysfs_emit(buf, "%04x\n", val);

}



static ssize_t value_store(struct device *dev, struct device_attribute *attr,