Commit cd2e6024 authored by Christoph Hellwig's avatar Christoph Hellwig Committed by Andrew Morton
Browse files

hpfs: remove ->writepage 

->writepage is a very inefficient method to write back data, and only
used through write_cache_pages or a a fallback when no ->migrate_folio
method is present.

Set ->migrate_folio to the generic buffer_head based helper, and remove
the ->writepage implementation.

Link: https://lkml.kernel.org/r/20221202102644.770505-6-hch@lst.de


Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
Acked-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
parent 12f9b9a7

fs/hpfs/file.c

+2 −7
Original line number Diff line number Diff line
@@ -163,11 +163,6 @@ static int hpfs_read_folio(struct file *file, struct folio *folio) 
	return mpage_read_folio(folio, hpfs_get_block);

}



static int hpfs_writepage(struct page *page, struct writeback_control *wbc)

{

	return block_write_full_page(page, hpfs_get_block, wbc);

}



static void hpfs_readahead(struct readahead_control *rac)

{

	mpage_readahead(rac, hpfs_get_block);
@@ -248,12 +243,12 @@ const struct address_space_operations hpfs_aops = { 
	.dirty_folio	= block_dirty_folio,

	.invalidate_folio = block_invalidate_folio,

	.read_folio = hpfs_read_folio,

	.writepage = hpfs_writepage,

	.readahead = hpfs_readahead,

	.writepages = hpfs_writepages,

	.write_begin = hpfs_write_begin,

	.write_end = hpfs_write_end,

	.bmap = _hpfs_bmap

	.bmap = _hpfs_bmap,

	.migrate_folio = buffer_migrate_folio,

};



const struct file_operations hpfs_file_ops =