Commit cd246fa9 authored by Rafael J. Wysocki's avatar Rafael J. Wysocki
Browse files

thermal: core: Clean up thermal_list_lock locking 



Once thermal_list_lock has been acquired in
__thermal_cooling_device_register(), it is not necessary to drop it
and take it again until all of the thermal zones have been updated,
so change the code accordingly.

No expected functional impact.

Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent 0c7d0692

drivers/thermal/thermal_core.c

+2 −6
Original line number Diff line number Diff line
@@ -826,8 +826,6 @@ static void bind_cdev(struct thermal_cooling_device *cdev) 
	const struct thermal_zone_params *tzp;

	struct thermal_zone_device *pos = NULL;



	mutex_lock(&thermal_list_lock);



	list_for_each_entry(pos, &thermal_tz_list, node) {

		if (!pos->tzp && !pos->ops->bind)

			continue;
@@ -854,8 +852,6 @@ static void bind_cdev(struct thermal_cooling_device *cdev) 
			       tzp->tbp[i].weight);

		}

	}



	mutex_unlock(&thermal_list_lock);

}



/**
@@ -933,17 +929,17 @@ __thermal_cooling_device_register(struct device_node *np, 


	/* Add 'this' new cdev to the global cdev list */

	mutex_lock(&thermal_list_lock);



	list_add(&cdev->node, &thermal_cdev_list);

	mutex_unlock(&thermal_list_lock);



	/* Update binding information for 'this' new cdev */

	bind_cdev(cdev);



	mutex_lock(&thermal_list_lock);

	list_for_each_entry(pos, &thermal_tz_list, node)

		if (atomic_cmpxchg(&pos->need_update, 1, 0))

			thermal_zone_device_update(pos,

						   THERMAL_EVENT_UNSPECIFIED);



	mutex_unlock(&thermal_list_lock);



	return cdev;